Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new release #14

Closed
khanzadimahdi opened this issue Jan 9, 2019 · 6 comments
Closed

new release #14

khanzadimahdi opened this issue Jan 9, 2019 · 6 comments

Comments

@khanzadimahdi
Copy link
Contributor

khanzadimahdi commented Jan 9, 2019

please add new release for new features and update composer. tnx.

@khanzadimahdi
Copy link
Contributor Author

@tzsk please release the package in github, i want to use it in my project. tnx.

@tzsk
Copy link
Owner

tzsk commented Jan 10, 2019

@khanzadimahdi Well you can use composer require tzsk/sms:dev-master.

I still don't like the withDriver() function I'll make it via() then push a new release. Because of the DDD principal. It reads better. Also, will do a SMS Builder for the notificaion channel.

I'm also considering to change the syntax to Sms::via($gateway)->send($body)->to($recipients)->dispatch(). And also make it loggable and event drivent. So there is that.

If you want I can make an RC release for now.

@khanzadimahdi
Copy link
Contributor Author

khanzadimahdi commented Jan 10, 2019

it will be okay if you make RC in composer. using master for developing project has some issues, composer update commad can cause break changes in package.
tnx bro.

@khanzadimahdi
Copy link
Contributor Author

khanzadimahdi commented Jan 10, 2019

@khanzadimahdi Well you can use composer require tzsk/sms:dev-master.

I still don't like the withDriver() function I'll make it via() then push a new release. Because of the DDD principal. It reads better. Also, will do a SMS Builder for the notificaion channel.

I'm also considering to change the syntax to Sms::via($gateway)->send($body)->to($recipients)->dispatch(). And also make it loggable and event drivent. So there is that.

If you want I can make an RC release for now.

please have a seen on Channel ,we have withDriver method in that file , it should be changed into via

@tzsk
Copy link
Owner

tzsk commented Jan 11, 2019

Done & 1.3.0-rc is out now. Thanks.

@tzsk tzsk closed this as completed Jan 11, 2019
@khanzadimahdi
Copy link
Contributor Author

tnx my bro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants