Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS dependency #102

Open
ivanjaros opened this issue Oct 13, 2023 · 3 comments
Open

Remove AWS dependency #102

ivanjaros opened this issue Oct 13, 2023 · 3 comments

Comments

@ivanjaros
Copy link

There is no place for such thing in a library like this. It can easily be made into additional library or custom code. But it should not be a dependency.

@piyongcai
Copy link

I think so too.

@rawnly
Copy link

rawnly commented Dec 2, 2023

it' used here for the tests i believe https://github.com/u2takey/ffmpeg-go/blob/master/examples/example_test.go

@IncredibleLaser
Copy link

I investigated this issue because of the file size of the resulting go binary which pointed to aws being the main culprit.

Anyhow, I don't use AWS and I'm not sure why it would be incorporated at ffmpeg wrapper level, but in case someone is curious, for my particular case, the binary built solely with go build shrank from 14MB to 4MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants