Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate specific cosmetic filters not discarded when "Ignore generic" is enabled #325

Closed
joey04 opened this issue Dec 3, 2018 · 1 comment
Labels
bug Something isn't working fixed issue has been addressed

Comments

@joey04
Copy link

joey04 commented Dec 3, 2018

Found this bug while making some changes in my own fork today.

duplicateBuster.add() is located on the wrong line in skipGenericCompiledContent. Thus duplicate specific cosmetics aren't detected with ignoreGenerics enabled.

Fix: instead of the current line it should be moved 8 lines earlier. This makes it the same as fromCompiledContent which is already correct.

@gorhill gorhill added the invalid not a uBlock issue label Dec 3, 2018
@gorhill gorhill closed this as completed Dec 3, 2018
@gorhill gorhill reopened this Dec 3, 2018
@gorhill gorhill removed the invalid not a uBlock issue label Dec 3, 2018
@gorhill
Copy link
Member

gorhill commented Dec 3, 2018

Sorry for marking as invalid, I had created a quick test case to validate the issue, and I observed the result was that the duplicate was seemingly detected. Turned out I had forgotten to disable the parsing of generic cosmetic filters, then I could see the duplicate not being discarded in the "Filter lists" pane.

@gorhill gorhill added bug Something isn't working fixed issue has been addressed labels Dec 3, 2018
@gorhill gorhill changed the title duplicateBuster bug Duplicate specific cosmetic filters not discarded when "Ignore generic" is enabled Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants