You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found this bug while making some changes in my own fork today.
duplicateBuster.add() is located on the wrong line in skipGenericCompiledContent. Thus duplicate specific cosmetics aren't detected with ignoreGenerics enabled.
Fix: instead of the current line it should be moved 8 lines earlier. This makes it the same as fromCompiledContent which is already correct.
The text was updated successfully, but these errors were encountered:
Sorry for marking as invalid, I had created a quick test case to validate the issue, and I observed the result was that the duplicate was seemingly detected. Turned out I had forgotten to disable the parsing of generic cosmetic filters, then I could see the duplicate not being discarded in the "Filter lists" pane.
Found this bug while making some changes in my own fork today.
duplicateBuster.add()
is located on the wrong line inskipGenericCompiledContent
. Thus duplicate specific cosmetics aren't detected with ignoreGenerics enabled.Fix: instead of the current line it should be moved 8 lines earlier. This makes it the same as
fromCompiledContent
which is already correct.The text was updated successfully, but these errors were encountered: