Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specification.md out of date with respect to devices #21

Closed
mspiegel opened this issue Jan 13, 2015 · 5 comments
Closed

specification.md out of date with respect to devices #21

mspiegel opened this issue Jan 13, 2015 · 5 comments

Comments

@mspiegel
Copy link

The section on device_parsers lists 'family_replacement', 'brand_replacement', and 'model_replacement' fields. After commit 22ef8a1 it looks like devices has the fields 'device_replacement', 'brand_replacement', and 'model_replacement'. Also it seems like all devices have all three fields explicitly enumerated and there doesn't appear to be an implicit match ordering as with the user_agent or operating system section. Is the documentation out of date?

@mspiegel
Copy link
Author

Maybe device_replacement should be family_replacement in the yaml file?

@mspiegel
Copy link
Author

Or maybe device_replacement remains as is. And there is a field labelled 'device' that lives under the group 'device'. I am unclear of the intent behind the most recent change.

@tobie
Copy link
Contributor

tobie commented Jan 15, 2015

@mspiegel Thanks for your reports, is that the same issue as the one you brought up on the mailing list?

@mspiegel
Copy link
Author

yeah. I think I phrased the question better on the mailing list. I can close this ticket out.

@tobie
Copy link
Contributor

tobie commented Jan 15, 2015

See mailing list thread.

@tobie tobie closed this as completed Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants