-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specification.md out of date with respect to devices #21
Comments
Maybe device_replacement should be family_replacement in the yaml file? |
Or maybe device_replacement remains as is. And there is a field labelled 'device' that lives under the group 'device'. I am unclear of the intent behind the most recent change. |
@mspiegel Thanks for your reports, is that the same issue as the one you brought up on the mailing list? |
yeah. I think I phrased the question better on the mailing list. I can close this ticket out. |
See mailing list thread. |
The section on device_parsers lists 'family_replacement', 'brand_replacement', and 'model_replacement' fields. After commit 22ef8a1 it looks like devices has the fields 'device_replacement', 'brand_replacement', and 'model_replacement'. Also it seems like all devices have all three fields explicitly enumerated and there doesn't appear to be an implicit match ordering as with the user_agent or operating system section. Is the documentation out of date?
The text was updated successfully, but these errors were encountered: