Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing domain query error #6

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Fixing domain query error #6

merged 3 commits into from
Feb 23, 2023

Conversation

wilkb777
Copy link
Member

@wilkb777 wilkb777 commented Feb 22, 2023

This PR fixes #4 along with making some adjustments to the URL and parsing strategy to make it easier to update/maintain in the future.

This can be tested by deploying the app and checking that the gene in the linked issue displays correctly without errors now.

@wilkb777 wilkb777 self-assigned this Feb 22, 2023
src/ui_ditto.py Outdated Show resolved Hide resolved
src/ui_ditto.py Show resolved Hide resolved
Copy link
Member

@tkmamidi tkmamidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@wilkb777 wilkb777 merged commit a84f544 into main Feb 23, 2023
@wilkb777 wilkb777 deleted the domain-query-fix branch February 23, 2023 20:10
wilkb777 added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains query parsing fails for some genes, but not others
2 participants