-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on characterization in development environment based on ENV var. #535
Conversation
@@ -56,5 +56,5 @@ | |||
config.active_storage.service = (ENV['ACTIVE_STORAGE_SERVICE'] || :local).to_sym | |||
|
|||
# FITS characterization | |||
config.run_fits_characterization = false | |||
config.run_fits_characterization = ENV['RUN_FITS_CHARACTERIZATION'].present? || false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just throw a small note in the README about how to enable fits in development mode using this ENV VAR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, was going to do that, completely forgot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -141,6 +141,7 @@ def add_files(files) | |||
self.ordered_members += [unlocked_fileset] | |||
if Rails.configuration.run_fits_characterization | |||
Hydra::Works::CharacterizationService.run(unlocked_fileset.original_file) | |||
unlocked_fileset.original_file.save |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment here for motivation about this change:
No description provided.