Fixing the use of spanish translations #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsook
pushed a commit
that referenced
this pull request
Jan 13, 2020
There is a problem with the translations (see #159) The translations catalog(ubcpi/static/js/src/translations.js) is generated using locale names and translations from transifex. The django.utils.translation.get_language() function returns the language code (i.e. es-419), but since in the catalog we are using locale names(i.e. es_419), the strings are not being translated as expected. With this change, now we are using the locale names and it works fine. I tested this with spanish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, ubcpi use the django language for spanish es-419, instead of es_419, so the spanish translations are not used.
This renames the es_419 folder to es-419, fixing the translation for the spanish language. I don't know if this is the best way, and if someone has a recommendation we can work on it.