Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixing the use of spanish translations" #169

Closed
wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Feb 17, 2020

Reverts #159

Since #163 was merged, I think that we need to revert this since it is now using the locale names instead of the language names.

@morenol morenol requested a review from kitsook February 17, 2020 22:49
@coveralls
Copy link

coveralls commented Feb 17, 2020

Coverage Status

Coverage remained the same at 95.61% when pulling b4a2816 on eduNEXT:revert-159-eol into e828d73 on ubc:master.

@morenol
Copy link
Contributor Author

morenol commented Jun 29, 2020

Hi @kitsook, do you have any updates on this?

@kitsook
Copy link
Contributor

kitsook commented Jun 30, 2020

hi @morenol . thx for reminding us about this. since we have a new UI, i regenerated the javascript and committed with b5b960c . We will need to do the translation for any new strings though.

@morenol
Copy link
Contributor Author

morenol commented Jun 30, 2020

hi @morenol . thx for reminding us about this. since we have a new UI, i regenerated the javascript and committed with b5b960c . We will need to do the translation for any new strings though.

Thanks!

Will you push the new strings to transifex?

@morenol morenol closed this Jun 30, 2020
@morenol morenol deleted the revert-159-eol branch June 30, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants