Use locale name instead of language name

[morenol]

There is a problem with the translations (see #159)

The translations catalog(ubcpi/static/js/src/translations.js) is generated using locale names and translations from transifex.

The django.utils.translation.get_language() function returns the language code (i.e. es-419), but since in the catalog we are using locale names(i.e. es_419), the strings are not being translated as expected.

With this change, now we are using the locale names and it works fine. I tested this with spanish

[coveralls]

Coverage increased (+0.008%) to 96.715% when pulling 8770d2e on eduNEXT:lmm/translations into 998a52f on ubc:master.

[morenol]

Hello @kitsook, Can you review this?

[kitsook]

Hi @morenol , thanks for submitting this pull request. Give me some time to check what is the best way to handle the translations for openedx.

As for #159, we probably shouldn't edit translations.js directly and the file is generated dynamically.

ubcpi/Makefile

Lines 58 to 64 in 998a52f

	compile:
	for i in `find ubcpi/translations/ -name *.po`; do msgfmt $$i -o `dirname $$i`/text.mo; done
	node_modules/.bin/angular-gettext-cli --compile --files 'ubcpi/translations/**/*.po' --format javascript --dest 'ubcpi/static/js/src/translations.js'
	pull_translations:
	tx pull --force --mode=reviewed -l=ar,es_419,ja_JP,fr,fr_CA,he,hi,ko_KR,pt_BR,ru,zh_CN,de_DE,pl
	make compile

I wonder if we should also change the tx pull --force --mode=reviewed -l=ar,es_419... line accordingly

[morenol]

Hello @kitsook, I tried to change that line but it didn't work because the transifex project uses also the locale name: https://www.transifex.com/open-edx/xblocks/ubcpi-peer-instruction/

For that reason I used this approach.

On the other hand, I think that we should change the line:

tx pull --force --mode=reviewed -l=ar,es_419,ja_JP,fr,fr_CA,he,hi,ko_KR,pt_BR,ru,zh_CN,de_DE,pl 

with something that can pull all the languages from transifex without restriction.

In the edx-ora2 project it is not being used the -l paramater, instead they use the --minimum-perc parameter to pull all the translation from the languages that have at least 1% of reviewed translations.

https://github.com/edx/edx-ora2/blob/283776514efc1940c9c98d756cba4590607a13cd/Makefile#L60

[kitsook]

@xcompass I would suggest to merge this PR instead of #159. transifex is using locale codes to identify translations. This change is more appropriate than modifying individual translation packages and translations.js directly.

As for modifying tx pull... to get all the translations, we can further discuss the criteria and review rate etc.

[morenol]

@kitsook Any updates on this?

If we run the command to update the translations, the changes applied in the last PR merged will disappear.