Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminRoutes.getResults is an inferior duplicate of AdminRoutes.getDashboard #157

Open
aahung opened this issue Oct 29, 2018 · 2 comments
Open
Assignees

Comments

@aahung
Copy link
Contributor

aahung commented Oct 29, 2018

AdminRoutes.getDashboard and AdminRoutes.getResults are highly similar with the following difference

  1. AdminRoutes.getDashboard has max result number 500, while AdminRoutes.getResults is 1000
  2. AdminRoutes.getResults misses testPass, testFail, testError and testSkip in AdminRoutes.getDashboard
  3. AdminRoutes.getResults does not do Util.truncateNumber(<score>, 0);

For tidy endpoints, I think we should keep AdminRoutes.getDashboard and change the name to AdminRoutes.getResults.

@aahung aahung changed the title AdminRoutes.getResults is inferior duplicate of AdminRoutes.getDashboard AdminRoutes.getResults is an inferior duplicate of AdminRoutes.getDashboard Oct 29, 2018
@aahung
Copy link
Contributor Author

aahung commented Oct 29, 2018

Diff can be found here

@aahung
Copy link
Contributor Author

aahung commented Oct 29, 2018

If we need a version of getResults to exclude test***, we could have one extra parameter, let's say results/deliverId/repo/summary

@rtholmes rtholmes self-assigned this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants