Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classlists cannot have DOS-formatted (CR/LF) lines #88

Open
rtholmes opened this issue Sep 4, 2018 · 2 comments
Open

Classlists cannot have DOS-formatted (CR/LF) lines #88

rtholmes opened this issue Sep 4, 2018 · 2 comments

Comments

@rtholmes
Copy link
Contributor

rtholmes commented Sep 4, 2018

The classlist utility doesn't make these by default, but if you're using Windows you might run into this problem if your copying the output from the terminal instead of piping it directly or using rsync/scp.

@andrewstec
Copy link
Contributor

andrewstec commented Apr 30, 2020

I believe this is not an issue. I have tried upload a classlist with CRLF (DOS) and LF (UNIX) formats. You can see the line-endings in the images here:

CRLF (DOS):
image

LF (UNIX):
image

In both cases, I get upload success messages on the back-end and see no problems with the class list student data:

DOS upload -->

portal      | <I> 4/30/2020, 3:33:30 PM: DatabaseController::writeAudit( Classlist_Upload, removedmyusername, hasBefore: false, hasAfter: false ) - start
portal      | <T> 4/30/2020, 3:33:30 PM: DatabaseController::writeRecord( audit, ...) - writing
portal      | <I> 4/30/2020, 3:33:30 PM: AdminRoutes::postClasslist(..) - done: Classlist upload successful. 9 students processed.

UNIX upload -->

portal      | <I> 4/30/2020, 3:36:27 PM: DatabaseController::writeAudit( Classlist_Upload, removedmyusername, hasBefore: false, hasAfter: false ) - start
portal      | <T> 4/30/2020, 3:36:27 PM: DatabaseController::writeRecord( audit, ...) - writing
portal      | <I> 4/30/2020, 3:36:27 PM: AdminRoutes::postClasslist(..) - done: Classlist upload successful. 9 students processed.

@andrewstec
Copy link
Contributor

andrewstec commented Apr 30, 2020

I did discover another issue while testing in this area, which may be the issue that you are experiencing.

The issue is a front-end bug that occurs when a file is modified after it has already been selected in the UI:

image

Steps to re-create:

  1. Select a classlist file to upload in the UI. It should appear next to the "Upload Classlist" button.
    image
  2. Do not click "Upload Classlist"
  3. Make a slight change in the file that you selected to upload.
  4. Click "Upload Classlist"
  5. You should see this error:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants