Seerat/241 country flag selection #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeratSek
force-pushed
the
seerat/241-country-flag-selection
branch
from
5c7de7e
to
87c2ee2
Compare
SeeratSek
added
the
ready for review
| "VE": "Venezuela, Bolivarian Republic of", | ||
| "VG": "Virgin Islands, British", | ||
| "VI": "Virgin Islands, U.S.", | ||
| "VN": "Viet Nam", |
There was a problem hiding this comment.
I never knew Vietnam was spelled like this 😩
server/game/game.go
Outdated
|
|
||
| err := g.Arena.SpawnPlayer(id, spawn.Name) | ||
| fmt.Println(spawn.Country) | ||
| err := g.Arena.SpawnPlayer(id, spawn.Name, spawn.Country) |
There was a problem hiding this comment.
If this print was for debugging, can you remove it? :)
| @@ -38,6 +38,7 @@ type KeysPressed struct { | |||
| type Player struct { | |||
| Name string `json:"name"` | |||
| ID string `json:"id"` | |||
| Country string `json:"country"` | |||
| Object.keys(countries).forEach((key) => { | ||
| listOfCountries.push(<option value={countries[key]} key={key}>{countries[key]} {key.toUpperCase().replace(/./g, char => String.fromCodePoint(char.charCodeAt(0) + 127397))} </option>); | ||
| }); | ||
| } |
There was a problem hiding this comment.
I like this very much
brian-nguyen
previously approved these changes
Jul 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #241
👷 Changes
🔦 Testing Instructions
Can test by pulling the branch changes and testing the dropdown as well as testing whether dying causes the country to persist.