handle double spend within pool

ubclaunchpad · Jul 26, 2017 · 815f38e · 815f38e
1 parent c5b2ab3
commit 815f38e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/pool/pool.go b/pool/pool.go
@@ -86,7 +86,12 @@ func (p *Pool) SetUnsafe(t *blockchain.Transaction) {
 }
 
 // Silently adds a transaction to the pool.
+// Deletes a transaction if it exists from the same
+// input hash.
 func (p *Pool) set(t *blockchain.Transaction) {
+	if txn, ok := p.ValidTransactions[t.Input.Hash]; ok {
+		p.Delete(txn.Transaction)
+	}
 	vt := &PooledTransaction{
 		Transaction: t,
 		Time:        time.Now(),

diff --git a/pool/pool_test.go b/pool/pool_test.go
@@ -121,3 +121,14 @@ func TestPop(t *testing.T) {
 	p := New()
 	assert.Nil(t, p.Pop())
 }
+
+func TestSetDedupes(t *testing.T) {
+	p := New()
+	t1 := blockchain.NewTestTransaction()
+	t2 := blockchain.NewTestTransaction()
+	t1.Input.Hash = t2.Input.Hash
+	p.SetUnsafe(t1)
+	p.SetUnsafe(t2)
+	assert.Equal(t, p.Peek(), t2)
+	assert.Equal(t, p.Len(), 1)
+}