Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji tests complete; map built; added emoji address into console #119

Merged
merged 3 commits into from
Aug 7, 2017

Conversation

chadlagore
Copy link
Contributor

@chadlagore chadlagore commented Aug 3, 2017

Related Issue

emoji-town

This is a hex mapping to emojis. It might be nice to build a base32 mapping - makes the addresses smaller.

We are purveyors of the finest ascii art (and the rarest emoji).

What would you like to create?
 ❯ Wallet
   Transaction
Enter wallet name: emoji-town
πŸ’³  New hot wallet created!
πŸ™‹  Name: emoji-town
πŸ“«  Address: 0a631651b8040c39d9c84a8c9181195a2e373a3e
✊  Emoji Address: ✊ πŸ™Œ πŸƒπŸŒ΅ ☝️ πŸƒ βœ‹ ☝️ 🀘 πŸ„ ✊ πŸ‘ ✊ πŸ•‘ 🌡 🌷 🚁 🌷 πŸ•‘ πŸ„ πŸ‘ πŸ™Œ πŸ„ πŸ•‘ 🌷 ☝️ πŸ„ ☝️ ☝️ 🌷 βœ‹ πŸ™Œ ✌️ βš“οΈ 🌡 πŸ‘ 🌡 πŸ™Œ 🌡 βš“οΈ
>>>

Description

  • Add a thin veneer of emoji.

General:

  • Tests
  • Wiki

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 70.855% when pulling 10a75e6 on 114-emoji-town into 7eee1b7 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 70.855% when pulling 10a75e6 on 114-emoji-town into 7eee1b7 on dev.

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love this.

For later:
I think there is room to expand the emojiset we're using to make addresses shorter. Right now we're mapping 4bit -> emoji so emoji addresses are 40 characters long. It would be nice to map 8bit -> emoji and lower the address length to 20 characters

@@ -56,7 +57,8 @@ func (a Address) Repr() string {

// Emoji returns the users address as a string of emojis (TODO).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer todo?

@chadlagore
Copy link
Contributor Author

Agreed. This is a good first pass, there are some simple ways to shorten the address!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 70.855% when pulling ddcad5a on 114-emoji-town into 7eee1b7 on dev.

@chadlagore chadlagore merged commit b6d5e37 into dev Aug 7, 2017
@jordanschalm jordanschalm deleted the 114-emoji-town branch August 30, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants