125 save user info #134
Merged
125 save user info #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
approved these changes
Sep 21, 2017
app/user.go
Outdated
| } | ||
| } | ||
|
|
||
| // Public returns the public key (address) of the given user |
There was a problem hiding this comment.
Public key and address are not the same. Address is hash of key, is that right @chadlagore ?
There was a problem hiding this comment.
Good call, I'll remove that "(address)" comment, it's not really necessary.
app/user.go
Outdated
| // current working directory in JSON format. On success this returns | ||
| // a pointer to a new user constructed from the information in the file. | ||
| // If an error occurrs it is returned. | ||
| func Load(fileName string) (*User, error) { |
There was a problem hiding this comment.
I'd call this LoadUser since it's in the app namespace. app.Load seems like it should load the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #125
Closes #131
Description
SaveandLoadfunctions to user and blockchain to save and load their contents from disk on startup.usercommand to the console to view and edit user info.WIKI Updates
Todos
General: