15 implement verification #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests
…lement-verification
29 makefile
…ment-verification
jordanschalm
approved these changes
May 30, 2017
blockchain/block.go
Outdated
|
|
||
| // ContainsTransaction returns true and the transaction itself if the Block | ||
| // contains the transaction. | ||
| func (b *Block) ContainsTransaction(t *Transaction) bool { |
| @@ -70,3 +70,14 @@ func DecodeBlock(r io.Reader) *Block { | |||
| gob.NewDecoder(r).Decode(&b) | |||
| return &b | |||
| } | |||
|
|
|||
| // ContainsTransaction returns true and the transaction itself if the Block | |||
| // contains the transaction. | |||
There was a problem hiding this comment.
"and the transaction itself"?
There was a problem hiding this comment.
Seems like the right thing to do doesn't it. Breaks my if block.ContainsTransaction(t) then idiom 😢 Forgot the comment in there 😆
blockchain/blockchain.go
Outdated
| hash := HashSum(t.TxBody) | ||
| if !ecdsa.Verify(t.Sender.Key(), hash.Marshal(), t.Sig.R, t.Sig.S) { | ||
| return false | ||
| } | ||
|
|
||
| // Validate chain from input block to last block. | ||
| // Test if identical transaction already exits in chain. |
| @@ -123,7 +123,8 @@ func newTransactionValue(s, r Wallet, a uint64) (*Transaction, error) { | |||
| return tbody.Sign(s, crand.Reader) | |||
| } | |||
|
|
|||
| func newValidBlockChainFixture() *BlockChain { | |||
| // newValidBlockChainFixture creates a valid blockchain of two blocks. | |||
| func newValidBlockChainFixture() (*BlockChain, Wallet) { | |||
There was a problem hiding this comment.
These test utils are awesome 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready for review.
What Changed
BlockChain(respend attack) - test caseTestTransactionRespend.BlockChain.AppendBlockandBlock.ContainsTransaction.How To Test Drive This PR
go test