Model for peer connections #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I moved extractPeerInfo() down to near the bottom of peer.go (because it's not exported)
Message layer
…mulus into 31-create-connections
…ad/cumulus into 31-create-connections
…chpad/cumulus into 51-model-for-connections
jordanschalm
commented
Jun 7, 2017
| func (ps *PeerStore) Addrs() []string { | ||
| ps.lock.RLock() | ||
| defer ps.lock.RUnlock() | ||
| addrs := make([]string, len(ps.peers), len(ps.peers)) |
There was a problem hiding this comment.
Don't need the third argument cap unless it's greater than second argument.
There was a problem hiding this comment.
Irrelevant now that I switched the peerstore back to a map. Didn't know we could iterate over a map back then.... my bad.
jordanschalm
commented
Jun 7, 2017
peer/peer.go
Outdated
| switch push.ResourceType { | ||
| case message.ResourcePeerInfo: | ||
| for _, addr := range push.Resource.([]string) { | ||
| conn.Listen(addr, func(c net.Conn) { |
There was a problem hiding this comment.
Yup this is one of those bugs I was telling you about..... just garbage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.