77 Cumulus Console and Peer updates #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanschalm
approved these changes
Jul 3, 2017
| // Start a goroutine that waits for program termination. Before the program | ||
| // exits it will flush logs and save the blockchain. | ||
| c := make(chan os.Signal, 1) | ||
| signal.Notify(c, os.Interrupt, syscall.SIGTERM) |
| @@ -34,14 +55,25 @@ func Run(cfg conf.Config) { | |||
| // Start listening on the given interface and port so we can receive | |||
| // conenctions from other peers | |||
| log.Infof("Starting listener on %s:%d", cfg.Interface, cfg.Port) | |||
| peer.LocalAddr = fmt.Sprintf("%s:%d", cfg.Interface, cfg.Port) | |||
| peer.ListenAddr = fmt.Sprintf("%s:%d", cfg.Interface, cfg.Port) | |||
| // RunConsole starts the Cumulus console. This should be run only once as a | ||
| // goroutine, and logging should be redirected away from stdout before it is run. | ||
| func RunConsole() { | ||
| shell = ishell.New() |
| "Wallet", | ||
| "Transaction", | ||
| }, "What would you like to create?") | ||
| if choice == 0 { |
There was a problem hiding this comment.
symbolic constant for this?
| } else { | ||
| shell.Println("Connected to", addr) | ||
| } | ||
| } |
There was a problem hiding this comment.
This console looks great. Nicely done Bruno
| @@ -1,33 +0,0 @@ | |||
| package cmd | |||
| return | ||
| } | ||
| p := New(c, PStore, addr) | ||
|
|
||
| // If we are already at MaxPeers, disconnect from a peer to connect to a new | ||
| // one. This way nobody gets choked out of the network because everybody | ||
| // happens to be fully connected. |
| if err != nil { | ||
| return false | ||
| } | ||
| return port > 1024 && port < 65536 |
There was a problem hiding this comment.
Port can be under 1024 technically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed:
exchangeListenAddrsto peer as a way of handshaking when peers establish a connection. We didn't do this before and it caused us to store incorrect peer addresses in the peerstore.cumulus run -c.Testto exported blockchain test fixtures so they don't confuse people.testpackage.