Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

93 create common folder #95

Merged
merged 9 commits into from
Jul 14, 2017
Merged

93 create common folder #95

merged 9 commits into from
Jul 14, 2017

Conversation

david-julien
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 70.135% when pulling 4b6db99 on 93-create-common-folder into f4f8b68 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 70.135% when pulling 4b6db99 on 93-create-common-folder into f4f8b68 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 70.135% when pulling f853ddc on 93-create-common-folder into f4f8b68 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 70.555% when pulling d942014 on 93-create-common-folder into f4f8b68 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 70.696% when pulling fd911d0 on 93-create-common-folder into f4f8b68 on dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 70.757% when pulling 06cb4a9 on 93-create-common-folder into f4f8b68 on dev.

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this! I think having subpackages (math) under common is overkill. I'd prefer either all in one package or just two packages util for utility functions and constants for the constants.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 70.757% when pulling f933cf9 on 93-create-common-folder into f4f8b68 on dev.

@david-julien david-julien mentioned this pull request Jul 14, 2017
3 tasks
@jordanschalm jordanschalm merged commit b6c46ea into dev Jul 14, 2017
@jordanschalm jordanschalm deleted the 93-create-common-folder branch July 14, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants