Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96 create pr template #97

Closed
wants to merge 3 commits into from
Closed

96 create pr template #97

wants to merge 3 commits into from

Conversation

david-julien
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.05% when pulling bf300f7 on 96-create-PR-template into f4f8b68 on dev.

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the description text that the PR creator will have to replace with their own text as short and easy to replace as possible (one line each). Otherwise looks good and I think it'll help a lot

## Status
**READY/IN DEVELOPMENT**

## Related Issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZenHub has a feature for doing this at the bottom of the PR page. Let's use that instead (we could put a note in the template to connect the PR to the issue using that feature)

* List general components of the application that this PR will affect.

## WIKI Updates
* [link]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just put one line of links here so we don't have to delete a bunch of lines for each PR

- [ ] Documentation
- [ ] Wiki

Other (links to TODOs in code):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, don't think we need all these links as we'll be deleting them each time

## Extra Changes/Bug Fixes
List any extra quick changes or bug fixes on this branch.

* ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditch this

@david-julien david-julien deleted the 96-create-PR-template branch July 15, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants