-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96 create pr template #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make the description text that the PR creator will have to replace with their own text as short and easy to replace as possible (one line each). Otherwise looks good and I think it'll help a lot
## Status | ||
**READY/IN DEVELOPMENT** | ||
|
||
## Related Issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZenHub has a feature for doing this at the bottom of the PR page. Let's use that instead (we could put a note in the template to connect the PR to the issue using that feature)
* List general components of the application that this PR will affect. | ||
|
||
## WIKI Updates | ||
* [link]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just put one line of links here so we don't have to delete a bunch of lines for each PR
- [ ] Documentation | ||
- [ ] Wiki | ||
|
||
Other (links to TODOs in code): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, don't think we need all these links as we'll be deleting them each time
## Extra Changes/Bug Fixes | ||
List any extra quick changes or bug fixes on this branch. | ||
|
||
* ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditch this
No description provided.