Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login fails - improve web app authentication #187

Closed
bobheadxi opened this issue May 2, 2018 · 1 comment
Closed

Login fails - improve web app authentication #187

bobheadxi opened this issue May 2, 2018 · 1 comment
Assignees
@bobheadxi
Labels
:daemon daemon and serverside functionality todo: priority do as soon as possible! type: bug 🐛 something's wrong!
Milestone
v0.4.0

Comments

@bobheadxi
Copy link
Member

Doesn't seem to work for @PiggySpeed and @brian-nguyen, but I can't seem to reproduce. Issue seems to be that login succeeds, but cookie does not get set.

Maybe should move away from set-cookies for authentication
@bobheadxi bobheadxi added type: bug 🐛 something's wrong! :web inertia web labels May 2, 2018
@bobheadxi bobheadxi added this to the v0.3.1 milestone May 2, 2018
@bobheadxi bobheadxi added the todo: priority do as soon as possible! label May 7, 2018
@bobheadxi bobheadxi changed the title Login fails Login fails - improve web app authentication May 22, 2018
@PiggySpeed PiggySpeed self-assigned this May 26, 2018
@bobheadxi
Copy link
Member Author

JWT's:

  • CLI JWT with no expiry
  • web client JWT with expiry + role

@bobheadxi bobheadxi assigned bobheadxi and unassigned PiggySpeed Jun 16, 2018
@bobheadxi bobheadxi added :daemon daemon and serverside functionality and removed :web inertia web labels Jun 29, 2018
This was referenced Jun 29, 2018
Closed
Merged
Closed
bobheadxi added a commit that referenced this issue Jun 30, 2018
@bobheadxi
Merge branch 'master' into daemon/#187-authentication
1c2a9e6
@bobheadxi bobheadxi mentioned this issue Jun 30, 2018
Merged
bobheadxi added a commit that referenced this issue Jun 30, 2018
@bobheadxi
Merge pull request #291 from ubclaunchpad/daemon/#187-authentication
db05354 
JWT-based authentication rework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobheadxi bobheadxi

Labels
:daemon daemon and serverside functionality todo: priority do as soon as possible! type: bug 🐛 something's wrong!
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
2 participants
@PiggySpeed @bobheadxi