Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT-based authentication rework #291

Merged
merged 14 commits into from
Jun 30, 2018
Merged

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Jun 30, 2018

🎟️ Ticket(s): Closes #187


πŸ‘· Changes

UghhhhhhHHHHHSDFSDF:EJWIo

See commits for changes. Namely:

  • Slight refactoring of some crypto functionality out of auth into crypto
  • Removed all cookie functionality, replace with tokens + claims
  • Added some ugly hacks to get around CLI tokens not having claims yet (see TODO: in code)
  • Fixed small bug with provisioning not saving the configuration

πŸ”¦ Testing Instructions

run tests, particularly permissions_test.go

@bobheadxi bobheadxi added the pr: wip in progress but seeking feedback label Jun 30, 2018
@bobheadxi bobheadxi requested a review from a team June 30, 2018 09:33
@coveralls
Copy link

coveralls commented Jun 30, 2018

Pull Request Test Coverage Report for Build 1020

  • 123 of 155 (79.35%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 41.557%

Changes Missing Coverage Covered Lines Changed/Added Lines %
daemon/inertiad/project/deployment.go 0 1 0.0%
daemon/inertiad/auth/permissions.go 20 21 95.24%
cmd/provision.go 0 2 0.0%
daemon/inertiad/cmd.go 0 2 0.0%
daemon/inertiad/crypto/token.go 34 39 87.18%
daemon/inertiad/auth/users.go 24 30 80.0%
daemon/inertiad/auth/sessions.go 41 48 85.42%
daemon/inertiad/up.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
daemon/inertiad/auth/permissions.go 3 76.04%
Totals Coverage Status
Change from base Build 1004: 0.6%
Covered Lines: 1425
Relevant Lines: 3429

πŸ’› - Coveralls

@bobheadxi bobheadxi merged commit db05354 into master Jun 30, 2018
@bobheadxi bobheadxi deleted the daemon/#187-authentication branch June 30, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: wip in progress but seeking feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants