Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daemon internal configuration rework #269

Merged
merged 7 commits into from
Jun 23, 2018
Merged

Daemon internal configuration rework #269

merged 7 commits into from
Jun 23, 2018

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #166

👷 Changes

  • Moves daemon configuration into env
  • Completely gutted how configuration is managed internally by the daemon:
    • cfg.New() to load values from env
    • Several classes gutted to accommodate improved top-down configuration flow
    • Build code is now its own package build, streamlined build code and configuration

🔦 Testing Instructions

make test-all

@bobheadxi
Load configuration from ENV instead of hardcoded values
7205f42 
Image: ENV is set in final build stage
Local Daemon: ENV is hacked out of .env file
@bobheadxi
Hardcode build tool versions into tests
defd655
@bobheadxi
Rework daemon configuration, new package "build"
4a26e75 
* Centralized configuration provided by package cfg
* Build code is now its own package
* Gutted various classes to accommodate improved top-down configuration flow
@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Jun 23, 2018
@bobheadxi bobheadxi requested a review from a team June 23, 2018 07:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 892

  • 19 of 50 (38.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.2%) to 44.254%
Changes Missing Coverage Covered Lines Changed/Added Lines %
daemon/inertiad/up.go 0 2 0.0%
daemon/inertiad/cmd.go 0 4 0.0%
daemon/inertiad/daemon.go 0 12 0.0%
daemon/inertiad/project/deployment.go 19 32 59.38%
Files with Coverage Reduction New Missed Lines %
daemon/inertiad/project/deployment.go 4 49.42%
Totals Coverage Status
Change from base Build 876: -2.2%
Covered Lines: 1340
Relevant Lines: 3028
💛 - Coveralls

@bobheadxi bobheadxi merged commit 3c0c4b6 into master Jun 23, 2018
@bobheadxi bobheadxi deleted the daemon/#166-config-in-env branch June 23, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiggySpeed PiggySpeed Awaiting requested review from PiggySpeed

Assignees
No one assigned
Labels
pr: finalized needs review and final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobheadxi @coveralls