Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Duplicate line-length rules #84

Closed
ross- opened this issue Jan 14, 2015 · 8 comments
Closed

Duplicate line-length rules #84

ross- opened this issue Jan 14, 2015 · 8 comments

Comments

@ross-
Copy link

ross- commented Jan 14, 2015

When you have a line longer than your project limit, you have to disable two rules:

  /* eslint-disable max-len */
  // jscs:disable maximumLineLength

I recommend removing the jscs rule.

@Raynos
Copy link
Contributor

Raynos commented Jan 19, 2015

👍 @malandrew

Also running into disabling eslint and then having to disable jscs seperately.

@rhobot
Copy link

rhobot commented Jan 20, 2015

as a result, using flag --line-length won't work well. It doesn't override jscs's maximumLineLength rule.

@ross-
Copy link
Author

ross- commented Jan 20, 2015

@rhobot I believe that's a regression in 1.0.0

@Willyham
Copy link

👍 Having the same problem.

There are a few more which I don't disable but are definitely dupes and are noisy:

error  eslint    92:0    Multiple blank lines not allowed.      no-multiple-empty-lines
error  jscs      91:0    Multiple line break                    disallowMultipleLineBreaks

warning  eslint    84:81   Missing space before opening brace.       space-before-blocks
error    jscs      84:80   Missing space before opening curly brace  requireSpacesInNamedFunctionExpression

error  eslint    44:18   Strings must use singlequote.  quotes
error  jscs      44:18   Invalid quote mark found       validateQuoteMarks

@lxe
Copy link

lxe commented Jan 26, 2015

I like duplicate warnings. Fixing each one is killing 2 birds with one stone!

@Raynos
Copy link
Contributor

Raynos commented Jan 27, 2015

That's not useful, we need to get rid of duplicates so we can use one inline comment to turn them off.

@andrewdeandrade
Copy link
Contributor

This is fixed in this PR #90

@andrewdeandrade
Copy link
Contributor

Install v1.0.1 to get this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants