Add test env and move env helper to be usable everywhere #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glibsm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anuptalwalkar, @shawnburke and @sectioneight to be potential reviewers. |
ghost
reviewed
Jan 13, 2017
| // | ||
| // Useful, for example, to enable alternate functionality of some components | ||
| // during testing that might normally require network connectivity or a database | ||
| func IsTestEnv() bool { |
There was a problem hiding this comment.
There could be different environments with different purposes, e.g. staging, internal, etc. Shouldn't test be controlled by the service config as well?
There was a problem hiding this comment.
Based on the earlier discussion, I'll make some changes to this diff and remove this functionality.
Going to keep environmental knowledge restricted to the config package. Everything else should come from configuration values, rather than the knowledge of which environment the application is running in.
ascandella
reviewed
Jan 13, 2017
| @@ -51,7 +51,8 @@ var ( | |||
| ) | |||
|
|
|||
| var ( | |||
| _devEnv = "development" | |||
| _devEnv = "development" | |||
| _testEnv = "test" | |||
There was a problem hiding this comment.
interesting. did go compiler sneeze while processing this line? I thought unused vars were an error
ghost
approved these changes
Jan 13, 2017
|
Unused globals aren't errors :(
…On Fri, Jan 13, 2017 at 2:06 PM Alex ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#166 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAF7P8JNqjdgstTu6H77abANIso-oSADks5rR_VQgaJpZM4LiXFo>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.