Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize node support #162

Merged
merged 4 commits into from
Apr 13, 2019
Merged

Centralize node support #162

merged 4 commits into from
Apr 13, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 13, 2019

The Node related code needs to be carefully excluded from browser builds.

The Node related code in core was spread across a few directories, this consolidates the code in a single top-level node directory, making it easier to track.

@ibgreen ibgreen marked this pull request as ready for review April 13, 2019 16:54
@coveralls
Copy link

coveralls commented Apr 13, 2019

Coverage Status

Coverage decreased (-0.002%) to 28.037% when pulling 9ca860b on ib/centralize-node-support into 1f29f5c on master.

@ibgreen ibgreen merged commit aaff679 into master Apr 13, 2019
@ibgreen ibgreen deleted the ib/centralize-node-support branch April 13, 2019 17:20
belom88 added a commit that referenced this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants