Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown for 3d-tiles example and uncomment batchID parsing #185

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

xintongxia
Copy link

dropdown

@xintongxia xintongxia requested a review from ibgreen April 29, 2019 17:26
@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage decreased (-0.04%) to 29.766% when pulling 7ed6698 on xx/3d-pnts into 9067d6c on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 29.755% when pulling 0fd8180 on xx/3d-pnts into c20ba58 on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good progress here, approved.

I left some notes around some things that I suspect can probably be simplified, but that doesn't need to happen before landing this.

.eslintrc.js Outdated Show resolved Hide resolved
examples/3d-tiles/app.js Outdated Show resolved Hide resolved
examples/3d-tiles/babel.config.js Show resolved Hide resolved
@@ -0,0 +1,43 @@
// Copyright (c) 2019 Uber Technologies, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a scripts folder.

Wonder if this can be generalized and placed in root scripts.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the scripts need be transpiled. I don't want to introduce all the dependencies to root, so that's why I keep the scripts in example.

modules/3d-tiles/src/parsers/parse-3d-tile-point-cloud.js Outdated Show resolved Hide resolved
modules/3d-tiles/src/utils/array-slice.js Outdated Show resolved Hide resolved
@@ -0,0 +1,1177 @@
{
"Batched": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need such a complicated hierarchical list? Isn't it enough with just a list of the filenames?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some examples have 2 files, one is tileset.json and the other is a binary file. Other examples have more files, I am thinking we need all the files processed in order to see the complete example.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. The tileset.json should contain the URLs or at least filenames of all the other files (assuming they are tiles).

If that is the case, maybe we only need a list of tileset.json files...

@xintongxia xintongxia merged commit fc5154b into master Apr 29, 2019
@xintongxia xintongxia deleted the xx/3d-pnts branch April 29, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants