-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdown for 3d-tiles example and uncomment batchID parsing #185
Conversation
xintongxia
commented
Apr 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good progress here, approved.
I left some notes around some things that I suspect can probably be simplified, but that doesn't need to happen before landing this.
@@ -0,0 +1,43 @@ | |||
// Copyright (c) 2019 Uber Technologies, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a scripts
folder.
Wonder if this can be generalized and placed in root scripts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now the scripts need be transpiled. I don't want to introduce all the dependencies to root, so that's why I keep the scripts in example.
@@ -0,0 +1,1177 @@ | |||
{ | |||
"Batched": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need such a complicated hierarchical list? Isn't it enough with just a list of the filenames?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some examples have 2 files, one is tileset.json
and the other is a binary file. Other examples have more files, I am thinking we need all the files processed in order to see the complete example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. The tileset.json
should contain the URLs or at least filenames of all the other files (assuming they are tiles).
If that is the case, maybe we only need a list of tileset.json files...
Resolve comments