Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for Android and our sample app #900

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

msridhar
Copy link
Collaborator

Fixes #891. It's hard to add a regression test for this, but I manually tested that with the new configuration, NullAway errors are detected in the sample app. After this lands, I'd like to update the readme further to refer to this particular commit, so users can see the changes we needed to make.

@msridhar msridhar requested a review from yuxincs January 21, 2024 19:52
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (091ac38) 86.99% compared to head (96b696b) 86.99%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #900   +/-   ##
=========================================
  Coverage     86.99%   86.99%           
  Complexity     1958     1958           
=========================================
  Files            77       77           
  Lines          6319     6319           
  Branches       1223     1223           
=========================================
  Hits           5497     5497           
  Misses          418      418           
  Partials        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation updates LGTM.

Not saying that we should do this, but perhaps if this breaks more often we can consider adding an integration test CI job that sets this up and use regex to check that the output contains the expected errors 😃

@msridhar
Copy link
Collaborator Author

Not saying that we should do this, but perhaps if this breaks more often we can consider adding an integration test CI job that sets this up and use regex to check that the output contains the expected errors 😃

Yeah I'm hoping it doesn't come to that 🙂 But if needed, that would be a good way to test for regressions.

@msridhar msridhar enabled auto-merge (squash) January 25, 2024 17:59
@msridhar msridhar merged commit 115d683 into uber:master Jan 25, 2024
12 checks passed
@msridhar msridhar deleted the get-android-build-working branch January 25, 2024 18:07
akulk022 added a commit to akulk022/NullAway that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android : Build did not fail due to Null Derefence.
2 participants