Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.Service with placement.Placement in m3cluster #217

Closed
cw9 opened this issue Jun 25, 2019 · 1 comment
Closed

Update services.Service with placement.Placement in m3cluster #217

cw9 opened this issue Jun 25, 2019 · 1 comment

Comments

@cw9
Copy link

cw9 commented Jun 25, 2019

Hi,

I noticed you guys are using the services.Service interface from m3cluster, I would like to recommend you guys to switch to placement.Placement instead unless you need to filter by healthy/unhealthy nodes in the placement.

The Service interface is a thin wrapper on top of Placement interface and the main goal is to filter out unhealthy nodes but that behavior ended up not being used in m3, as you can see more operations has been built on Placement and PlacementService interface than service.Service (like MarkShardsAvailable etc).

I hope one day we can migrate m3 to placement.Placement only and deprecate services.Service, and removing external dependencies on services.Service would help reaching that.

Let me know if you have any concerns.

Thanks,
Chao

@jshencode
Copy link
Contributor

a quick search reveals our usage of services.Service interface is from the dynamic topology, which is derived from m3db's dynamic topology class. If you guys are rewriting the topology class, we can also migrate to the new implementation.

@cw9 cw9 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants