Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless field assignment in query_handler.go #272

Open
xiemaisi opened this issue Aug 6, 2019 · 1 comment
Open

Useless field assignment in query_handler.go #272

xiemaisi opened this issue Aug 6, 2019 · 1 comment

Comments

@xiemaisi
Copy link
Contributor

xiemaisi commented Aug 6, 2019

Describe the bug

It looks like this assignment to aqlRequest.Verbose is dead (the field is never read in the same function, and aqlRequest is not a pointer).

To Reproduce

I found this issue using static analysis, so I cannot provide reproduction steps. I imagine one possible outcome of this could be that this if condition never holds,

@hasitpbhatt
Copy link

Maybe it was done just in case someone needs to use aqlRequest.Verbose later in the same function. Not sure, though.

@shz117, can you help us out here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants