Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(text-area): removed redundant props #3001

Merged
merged 9 commits into from
Mar 9, 2020

Conversation

gwuah
Copy link
Contributor

@gwuah gwuah commented Mar 8, 2020

Fixes https://github.com/uber/baseweb/issues/2897

Description

This pull request removes redundant props directly inherited from input

@vercel
Copy link

vercel bot commented Mar 8, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/r07iscq9b
✅ Preview: https://baseweb-git-fork-gwuah-ga-remove-unwanted-input-props.uber-ui-platform.now.sh

@gwuah
Copy link
Contributor Author

gwuah commented Mar 8, 2020

Hi @chasestarr, kindly take a look at this pr.
Did I cover all the redundant props?

@vercel vercel bot temporarily deployed to Preview March 9, 2020 16:20 Inactive
@gwuah
Copy link
Contributor Author

gwuah commented Mar 9, 2020

Also can you add a label to my pull request?

@gergelyke gergelyke added the docs label Mar 9, 2020
@chasestarr chasestarr merged commit e976f99 into uber:master Mar 9, 2020
@gwuah gwuah deleted the ga/remove-unwanted-input-props branch March 9, 2020 19:29
cbranch101 pushed a commit to cbranch101/baseweb that referenced this pull request Mar 26, 2020
Co-authored-by: Chase Starr <chasestarr@gmail.com>
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
Co-authored-by: Chase Starr <chasestarr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextArea] docs site includes props that do not apply
3 participants