Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some persistence APIs to support sharded/partitioned SQL database and NoSQL database #4064

Open
longquanzheng opened this issue Mar 19, 2021 · 2 comments
Labels
improvement Incremental improvement for existing features

Comments

@longquanzheng
Copy link
Collaborator

longquanzheng commented Mar 19, 2021

Is your feature request related to a problem? Please describe.

Initially we wanted to design our SQL layer to support sharded/partitioned SQL DB. Hence all query are intentially using shardID and avoid doing cross shard query. Even though we haven't found a real use case yet.

However, in PR #4059 seems like we have to do cross shard query. Otherwise it will introduce a lot more complexity to the code.

We will this keep issue open, until we find some real use case of sharded SQL database in the future.

Proposed Solution
A clear and concise description of what you want to happen.
N/A

Additional context
Add any other context or screenshots about the feature request here.
N/A

@meiliang86
Copy link
Contributor

The current SQL interface/implementation works with sharded SQL (Uber iss going to use it), and we need to keep it that way.
We need to fix #4059 so it does not rely on cross shard operations (query might be fine, but definitely no transactions)

@Shaddoll
Copy link
Contributor

We found an issue with mysql schema. Current mysql implementation doesn't support sharding, we have to fix it so that we won't have cross shard transaction in sharded mysql.

@longquanzheng longquanzheng changed the title Redesign persistence to support sharded/partitioned SQL database Fix some persistence APIs to support sharded/partitioned SQL database and NoSQL database Sep 25, 2021
@ibarrajo ibarrajo added the improvement Incremental improvement for existing features label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Incremental improvement for existing features
Projects
None yet
Development

No branches or pull requests

4 participants