Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteWorkflowExecution is not transactional with workflow completion update #78

Closed
samarabbas opened this issue Mar 9, 2017 · 3 comments
Assignees
Labels

Comments

@samarabbas
Copy link
Contributor

When decider responds back with complete workflow decision, we first update the execution with new events and then delete workflow execution as a separate transaction. This can cause issues when the update times out but we successfully apply the update. This can cause us to never delete this workflow execution.
We need to make sure that execution is update and deleted in the same transaction.

@samarabbas samarabbas added the bug label Mar 9, 2017
@samarabbas samarabbas added this to the Cadence Release V0.1 milestone Mar 9, 2017
@samarabbas samarabbas self-assigned this Mar 9, 2017
@mfateev
Copy link
Contributor

mfateev commented Mar 9, 2017

Another option is to schedule a transfer task for delete. It would also work with archival of completed workflows to an external system.

@samarabbas
Copy link
Contributor Author

This sounds much cleaner approach. Let me code up the fix using transfer task.

@samarabbas
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants