Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

kafka phantom extents should not see extent-down events #146

Merged
merged 4 commits into from
Apr 13, 2017
Merged

kafka phantom extents should not see extent-down events #146

merged 4 commits into from
Apr 13, 2017

Conversation

kirg
Copy link
Contributor

@kirg kirg commented Apr 13, 2017

No description provided.

@kirg kirg requested a review from venkat1109 April 13, 2017 00:22
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6da1156 on kfc-extentmon into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6da1156 on kfc-extentmon into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e6c3b44 on kfc-extentmon into ** on master**.

venkat1109
venkat1109 approved these changes Apr 13, 2017
View reviewed changes
Copy link
Contributor

@venkat1109 venkat1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for isAnyStoreHealthy() and friends to make sure they return true for kafka extent ?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 68.658% when pulling c5730f2 on kfc-extentmon into 35bd2b1 on master.

@kirg kirg merged commit db00172 into master Apr 13, 2017
@kirg kirg deleted the kfc-extentmon branch April 13, 2017 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@venkat1109 venkat1109 venkat1109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirg @coveralls @venkat1109