This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
fix/add replicator counters #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat1109
reviewed
Jan 24, 2017
| @@ -902,8 +902,10 @@ const ( | |||
|
|
|||
| // -- Replicator metrics -- // | |||
|
|
|||
| // ReplicatorWsFailure indicates websocket failure | |||
| ReplicatorWsFailure | |||
| // ReplicatorWsFailure indicates failure when creating in stream | |||
| ReplicatorWsFailure | ||
| // ReplicatorWsFailure indicates failure when creating in stream | ||
| ReplicatorCreateInStreamFailure | ||
| // ReplicatorWsFailure indicates failure when creating out stream |
| ReplicatorReconcileDestExtentFail: {Counter, "replicator.reconcile.destextent.fail"}, | ||
| ReplicatorReconcileDestExtentFoundMissing: {Counter, "replicator.reconcile.destextent.foundmissing"}, | ||
| ReplicatorReconcileDestExtentInconsistentStatus: {Counter, "replicator.reconcile.destextent.inconsistentstatus"}, | ||
| ReplicatorReconcileDestRun: {Gauge, "replicator.reconcile.dest.run"}, |
There was a problem hiding this comment.
Don't you want to also update the callers to use UpdateGauge() instead of IncCounter() now ?
There was a problem hiding this comment.
caller is already using UpdateGauge, so this is a bug fix.
venkat1109
approved these changes
Jan 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some new counters in replicator, also fix existing gauge counters