Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

add health check in dockerfile #59

Merged
merged 10 commits into from
Feb 13, 2017
Merged

add health check in dockerfile #59

merged 10 commits into from
Feb 13, 2017

Conversation

datoug
Copy link
Contributor

@datoug datoug commented Feb 3, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 55.998% when pulling b13a06e on docker_fix into d89c79f on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 56.046% when pulling b13a06e on docker_fix into d89c79f on master.

WORKDIR $CHERAMI_HOME

# Remember to mount host directories (config and data), and have CHERAMI_CONFIG_DIR properly point to config.
CMD ["./cherami-server", "start", "all"]

HEALTHCHECK --interval=1s --timeout=1s --retries=120 CMD ./healthcheck.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this on server container? The "server" container can be started without frontend inside (e.g. docker run ... "./cherami-server start input output"), then this check will fail.

@@ -24,7 +24,7 @@
pushd /
./docker-entrypoint.sh cassandra
popd
sleep 20
sleep 40
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about someway to health check cassandra (e.g. via cqlsh -e 'desc system') instead of fixed sleep?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 56.027% when pulling 1ad97fb on docker_fix into 7e3c5f5 on master.

@thuningxu
Copy link
Contributor

There are couple of problems:

  1. I don't think the docker build is successful (see below logs).
  2. I also think you should try to do a docker build only on a master branch.
  3. Looks like you want to build a docker from local files. The Dockerfile does not support that because it retrieves master from github.
Step 16 : COPY ./start.sh $CHERAMI_HOME/start.sh
lstat start.sh: no such file or directory
after_success.7
0.02s$ docker tag $REPO:$COMMIT $REPO:$TAG
Error response from daemon: no such id: ubercherami/cherami-server-standalone:829b4874
after_success.8
0.02s$ docker tag $REPO:$COMMIT $REPO:travis-$TRAVIS_BUILD_NUMBER
Error response from daemon: no such id: ubercherami/cherami-server-standalone:829b4874
after_success.9
0.03s$ docker push $REPO
The push refers to a repository [docker.io/ubercherami/cherami-server-standalone]
An image does not exist locally with the tag: ubercherami/cherami-server-standalone

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 56.034% when pulling c229e86 on docker_fix into 7e3c5f5 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 56.032% when pulling 970e63f on docker_fix into 91f55dd on master.

@datoug datoug merged commit 44aedb9 into master Feb 13, 2017
@datoug datoug deleted the docker_fix branch February 13, 2017 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants