This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuningxu
suggested changes
Feb 4, 2017
docker/server/Dockerfile
Outdated
WORKDIR $CHERAMI_HOME | ||
|
||
# Remember to mount host directories (config and data), and have CHERAMI_CONFIG_DIR properly point to config. | ||
CMD ["./cherami-server", "start", "all"] | ||
|
||
HEALTHCHECK --interval=1s --timeout=1s --retries=120 CMD ./healthcheck.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do this on server container? The "server" container can be started without frontend inside (e.g. docker run ... "./cherami-server start input output"), then this check will fail.
docker/standalone/start.sh
Outdated
@@ -24,7 +24,7 @@ | |||
pushd / | |||
./docker-entrypoint.sh cassandra | |||
popd | |||
sleep 20 | |||
sleep 40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about someway to health check cassandra (e.g. via cqlsh -e 'desc system'
) instead of fixed sleep?
There are couple of problems:
|
thuningxu
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.