Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to h3Line algorithm: Support any great arc #195

Open
nrabinowitz opened this issue Feb 23, 2019 · 1 comment
Open

Improvement to h3Line algorithm: Support any great arc #195

nrabinowitz opened this issue Feb 23, 2019 · 1 comment
Labels
enhancement

Comments

@nrabinowitz
Copy link
Collaborator

Improved algo for h3Line that can cross arbitrary base cells with better fidelity than the current implementation:

  • Take the great arc between start and end
  • Subdivide the great arc by the icosahedron edges
  • Use the current implementation to draw lines for each line segment
  • Union the results

This should allow any arc >= 180 degrees, and ensure fidelity to the true great arc.

TODO: Prove that this is also the shortest grid distance (h3Distance).
@nrabinowitz
Copy link
Collaborator Author

Note that this should fix #184

@nrabinowitz nrabinowitz mentioned this issue Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrabinowitz