This repository has been archived by the owner on May 23, 2024. It is now read-only.
Fix zap logger Infof #100
Merged
Fix zap logger Infof #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Feb 22, 2017
| @@ -41,5 +41,5 @@ func (l *Logger) Error(msg string) { | |||
|
|
|||
| // Infof logs a message at info priority | |||
| func (l *Logger) Infof(msg string, args ...interface{}) { | |||
| l.logger.Infof(msg, args) | |||
| l.logger.Infof(msg, args...) | |||
There was a problem hiding this comment.
this indicates that you don't have correct unit tests for this
There was a problem hiding this comment.
kinda hard to testing logging without some kind of local backend which zap doesn't provide. I can write one and plug it into zap but seems a bit overkill
|
It's not that hard - https://github.com/uber/jaeger/blob/master/pkg/testutils/logger.go |
1 similar comment
yurishkuro
approved these changes
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.