This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add a structured way to extract traces for logging #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since opentracing implementations differ in how they represent tracing data (e.g., not all implementation use span and trace IDs), there isn't a generic way to add tracing information to log messages. This PR adds a small utility to Jaeger's zap integration that extracts structured data from a context.Context. This is an exact clone of the code currently in UberFX's `ulog` package; for easy re-usability, I think that this is a better place for it. I'm happy to remove the code in UberFX once this lands.
|
Thanks for the quick review! I don't have write access to this repo, so you'll have to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since opentracing implementations differ in how they represent tracing data
(e.g., not all implementation use span and trace IDs), there isn't a generic way
to add tracing information to log messages. This PR adds a small utility to
Jaeger's zap integration that extracts structured data from a context.Context.
This is an exact clone of the code currently in UberFX's
ulogpackage; foreasy re-usability, I think that this is a better place for it. I'm happy to
remove the code in UberFX once this lands.