Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgl: Avoid crashing debug log if attribute is null #1213

Merged
merged 2 commits into from
Aug 27, 2019
Merged

webgl: Avoid crashing debug log if attribute is null #1213

merged 2 commits into from
Aug 27, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Aug 27, 2019

For #

Background

  • Crashes during 3d-tiles debugging, deck somehow sets (fails to set) instance64lo attribute to null.
  • While this condition is pathological, it is better to avoid crashing during logging as that creates uncertainty about whether it is logging itself that is broken.

Change List

  • Check if attribute is null and print null row.

@coveralls
Copy link

coveralls commented Aug 27, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 62.086% when pulling 8b3a0a6 on ib/fix-debugger into e63bdb2 on master.

tsherif
tsherif approved these changes Aug 27, 2019
View reviewed changes
modules/webgl/src/debug/debug-vertex-array.js Outdated Show resolved Hide resolved
@tsherif
Copy link
Contributor

tsherif commented Aug 27, 2019

This issue seems similar: #1149

Was it ever fixed?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Aug 27, 2019

This issue seems similar: #1149

Looks like there are several issues inside that one. I am not aware of any other fixes. This PR only fixes the attribute===null part.

@ibgreen ibgreen merged commit 07d8a66 into master Aug 27, 2019
@ibgreen ibgreen deleted the ib/fix-debugger branch August 27, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsherif tsherif tsherif approved these changes

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibgreen @coveralls @tsherif