Update publish script #62
Conversation
|
It may be better to publish the dist folder using lerna (lerna/lerna#1282) to fix the subfolder import issue instead of adding back the proxy files. |
gnavvy
added
the
not-ready-for-review
v1.1.0-alpha.0 use lerna publish instead of ocular v1.1.0-alpha.1 use ocular publish v1.1.0-alpha.2 v1.1.0-alpha.3 v1.1.0-alpha.4 v1.1.0-alpha.4 v1.1.0-alpha.5 v1.1.0-alpha.6 v1.1.0-alpha.7 added public scope v1.1.0-alpha.8 add public scope v1.1.0-alpha.9 add public scope v1.1.0-alpha.10 v1.1.0-alpha.11 v1.1.0-alpha.12 remove root publish script v1.1.0-alpha.13 change dist/index.js to dist in package.json v1.1.0-alpha.14 add back proxy files v1.1.0-alpha.15 remove auto-deploy code use lerna publish
package.json
Outdated
| @@ -77,7 +77,7 @@ | |||
| "test": "jest", | |||
| "clean": "ocular-clean all", | |||
| "build": "ocular-clean all && ocular-build --dist esm && lerna run build", | |||
| "publish": "ocular-publish", | |||
| "publish": "lerna publish --force-publish --exact", | |||
There was a problem hiding this comment.
This is the main update: use lerna instead of ocular to publish
modules/manifold/actions.js
Outdated
| @@ -0,0 +1 @@ | |||
| module.exports = require('./dist/actions'); | |||
There was a problem hiding this comment.
Reverting #56, turns out we still have to use proxy files as long as the code is under /dist directory (non-root directory)
Firenze11
removed
the
not-ready-for-review
Firenze11
changed the title
Good idea, let me evaluate feasibility |
If the lerna approach doesn't work, we can write some publish script, which is quite easy. You can create an issue and assign to me if we take this approach. |
| "lerna:build": "lerna run build", | ||
| "lerna:clean": "lerna run clean", | ||
| "lerna:publish": "lerna run publish", | ||
| "lerna:publish": "lerna exec cp package.json dist && lerna exec npm publish dist", |
There was a problem hiding this comment.
Used lerna exec to publish /dist folders only
There was a problem hiding this comment.
same as above, use yarn publish instead.
| @@ -1,12 +1,15 @@ | |||
| { | |||
| "name": "@mlvis/jupyter-graph-builder", | |||
| "version": "1.0.0", | |||
| "version": "1.1.0-alpha.18", | |||
There was a problem hiding this comment.
do we plan to use the alpha version for production usage for now.
|
Please also change the PR description if the proxy files are not added back. |
| @@ -77,17 +76,15 @@ | |||
| "test": "jest", | |||
| "clean": "ocular-clean all", | |||
| "build": "ocular-clean all && ocular-build --dist esm && lerna run build", | |||
| "publish": "ocular-publish", | |||
| "publish": "npm run lerna:publish", | |||
There was a problem hiding this comment.
I've tried this, but doesn't work -- probably overridden by the default behavior of yarn publish (publishing the root package instead of running a script called "publish")
| "lerna:build": "lerna run build", | ||
| "lerna:clean": "lerna run clean", | ||
| "lerna:publish": "lerna run publish", | ||
| "lerna:publish": "lerna exec cp package.json dist && lerna exec npm publish dist", |
There was a problem hiding this comment.
same as above, use yarn publish instead.
Firenze11
changed the title
Summary | Related Issue(s)
import * from @mlvis/manifold/actions) still doesn't work despite ocular-build only builds esm version (configure ocular to build only esm #56), publish/distfolders directly instead.Testing
Have tested installing in Michelangelo.
Checklist