Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup proguard in generated dependencies #925

Open
kurtisnelson opened this issue Aug 5, 2020 · 2 comments
Open

Cleanup proguard in generated dependencies #925

kurtisnelson opened this issue Aug 5, 2020 · 2 comments
Assignees

Comments

@kurtisnelson
Copy link
Contributor

In buck, the proguard-gradle dependency is unused. Additionally, OkBuck internally pins to a version of proguard instead of allowing the consumer to specify it.

@raviagarwal7
Copy link
Collaborator

@kurtisnelson could you give an example?

Do you mean the proguard-gradle dependency generated in .buckconfig is not used?

Also proguard artifact version is looked up in the classpath https://github.com/uber/okbuck/blob/master/buildSrc/src/main/java/com/uber/okbuck/core/util/ProguardUtil.java#L24

Do we want the ability to specify a specific proguard version instead of auto lookup from the classpath?

@kageiit
Copy link
Contributor

kageiit commented Aug 5, 2020

I think the issue is two fold.

  • We don't need the proguard-gradle artifact
  • we can allow an override of the proguard jar target and set the default like we do today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants