Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message/handle for wrong mix future of predict and sample method #68

Closed
edwinnglabs opened this issue Apr 1, 2020 · 1 comment

Comments

@edwinnglabs
Copy link
Collaborator

for example,

  1. when we see "map" sample method, make better message and enforce predict method to "map"
  2. when we see "mcmc"/"vi" as sample method while "map" as predict method, enforce a "mean" predict method instead

Or just raise error in those wrong combinations?

@steveyang90
Copy link
Collaborator

Addressed in v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants