Create a GenericBuildTask to handle non-differential build invocations. #41
Conversation
|
What would be an example of a non-differential build invocation? You mean just building from Harbormaster? |
|
Building master is an example of a non-differential build invocation. Code wise, this will be building with a blank diffID |
| */ | ||
| @Override | ||
| protected String getTag() { | ||
| return "generic-build"; |
There was a problem hiding this comment.
this may be a little too generic for engineers outside of the two if us to understand in their build logs. perhaps call this "non-differential"? or something... naming is hard, but "generic-build" could mean anything
There was a problem hiding this comment.
Renamed this class to NonDifferentialBuildTask and updated the tag to be more explicit. We can change this name some where down the road if we get a better name.
|
Looks great! A few style questions just so I can learn to Java better. Merge at will. (aside from maybe the naming thing). |
| @@ -68,6 +68,13 @@ | |||
| <artifactId>jna</artifactId> | |||
| <version>3.2.2</version> | |||
| </dependency> | |||
| <!-- test dependencies --> | |||
There was a problem hiding this comment.
need to rebase, i already merged this to master
Add more Differential tests
Create NonDifferentialBuildTask to handle non-differential build invocations.
|
@jjx Doesn't the plugin already do this? If you build with the Git plugin pulling master, doesn't it have the same functionality? |
|
Yea, the plugin already does this, but it was mixing concerns. This doesn't change any functionality, just separates out the non-differential builds into its own task so the code is cleaner/more testable. |
|
Ooooohhhh. So it's just a refactor. I wish I knew java. |
|
you and me both :)
|
@sectioneight