Does Piranha support scala projects #199

eankit · 2022-06-27T09:07:50Z

Does Piranha have support for scala with current code or can it be supported with minimalistic changes in java?

mkr-plse · 2022-07-11T15:24:05Z

You can potentially add rules for Scala and make Piranha applicable for Scala. See here

ketkarameya · 2022-07-11T22:23:54Z

@eankit you can use https://github.com/tree-sitter/tree-sitter-scala for the grammar. I think the rules will be very similar to the ones implemented for Java/Kotlin.

eankit · 2022-12-06T04:11:53Z

can some help with how to and where to make changes in .rs files in the polygot piranha. I understand the .toml file syntaxes but it seems a lot goes into .rs files before it could be used in the toml file.
@ketkarameya @mkr-plse

ketkarameya · 2022-12-06T06:45:55Z

@eankit adding new language support requires very minimal changes .rs files . I am streamlining the implementation here - #283.

After this merges, it should be easy (though slightly tedious) to add scala support. I will update the README and keep you posted.

Basically you will have to do the following:

Add configurations for Scala (like the parser, rules, )
Write rules for cleaning up potentially stale code (You can get "inspiration" from our java or kotlin rules :) )
Write tests to show that your rules work.

eankit · 2022-12-09T11:42:03Z

Hey @ketkarameya
I am getting this error while building the latest code on master, similar error is seen if I add scala as new language along with typescript, removing the ts and TSX language specific code from language.rs things seems to work fine.
What am I doing wrong

_Building wheels for collected packages: polyglot_piranha
Building wheel for polyglot_piranha (pyproject.toml) ... error
error: subprocess-exited-with-error

× Building wheel for polyglot_piranha (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [33 lines of output]
Running maturin pep517 build-wheel -i /Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3 --compatibility off
📡 Using build options bindings from pyproject.toml
Compiling piranha v0.2.1 (/Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha)
error: could not compile piranha due to 3 previous errors
💥 maturin failed
Caused by: Failed to build a native library through cargo
Caused by: Cargo build finished with "exit status: 101": "cargo" "rustc" "--release" "--message-format" "json" "--lib" "--" "-C" "link-arg=-undefined" "-C" "link-arg=dynamic_lookup" "-C" "link-args=-Wl,-install_name,@rpath/polyglot_piranha.cpython-38-darwin.so"
🔗 Found pyo3 bindings
🐍 Found CPython 3.8 at /Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3
error[E0308]: mismatched types
--> src/models/language.rs:154:19
|
154 | language: tree_sitter_typescript::language_typescript(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

  error[E0308]: mismatched types
     --> src/models/language.rs:163:19
      |
  163 |         language: tree_sitter_typescript::language_tsx(),
      |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct `tree_sitter::Language`, found a different struct `tree_sitter::Language`
      |
      = note: perhaps two different versions of crate `tree_sitter` are being used?
  
  
  error: aborting due to 2 previous errors
  
  
  For more information about this error, try `rustc --explain E0308`.
  
  Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha/.env/bin/python3', '--compatibility', 'off'] returned non-zero exit status 1
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for polyglot_piranha
Failed to build polyglot_piranha
ERROR: Could not build wheels for polyglot_piranha, which is required to install pyproject.toml-based projects_

ketkarameya · 2022-12-09T14:58:50Z

I assume you get this error on adding the tree-sitter-scala right? I think there is a tree sitter version mismatch. How have u added it in Cargo.toml? Can you add the GitHub repo link there (like tree-sitter-java )

eankit · 2022-12-09T17:02:13Z

eankit · 2022-12-09T17:38:53Z

@ketkarameya upon fetching the latest pull from master, I am getting this error without adding scala. This error is coming for typescript also up doing a pip install .

ketkarameya · 2022-12-09T17:41:53Z

But the CI is passing . What machine are you using ? ubuntu /mac / windows?

eankit · 2022-12-09T17:42:31Z

I am on my local mac

ketkarameya · 2022-12-09T17:43:35Z

So you are able to build the application locally (with no changes)?

eankit · 2022-12-09T17:44:22Z

no I have to make some change to run it locally, if I remove typescript from your code/master it is building code correctly

eankit · 2022-12-09T17:49:45Z

@ketkarameya after making the below change I am able to run the pip install . successfully

diff --git a/polyglot/piranha/src/models/language.rs b/polyglot/piranha/src/models/language.rs
index d5a90fc..639e371 100644
--- a/polyglot/piranha/src/models/language.rs
+++ b/polyglot/piranha/src/models/language.rs
@@ -148,24 +148,6 @@ impl From<&str> for PiranhaLanguage {
scopes: vec![],
comment_nodes: vec![],
},

```
 "ts" => PiranhaLanguage {
```
```
   name: language.to_string(),
```

   supported_language: SupportedLanguage::Ts,

   language: tree_sitter_typescript::language_typescript(),

```
   rules: None,
```
```
   edges: None,
```
```
   scopes: vec![],
```
```
   comment_nodes: vec![],
```
```
 },
```
```
 "tsx" => PiranhaLanguage {
```
```
   name: language.to_string(),
```

   supported_language: SupportedLanguage::Tsx,

   language: tree_sitter_typescript::language_tsx(),

```
   rules: None,
```
```
   edges: None,
```
```
   scopes: vec![],
```
```
   comment_nodes: vec![],
```

 },
 _ => panic!("Language not supported"),

}
}

ketkarameya · 2022-12-09T17:58:54Z

I am using a Mac too. I did the following

git clone ...
cd piranha/polyglot/piranha directory.
Then ran the command cargo build --no-default-features (which ran successfully)

Are you doing the same?

eankit · 2022-12-09T18:02:50Z

I am following these steps

git clone https://github.com/uber/piranha.git
cd polyglot/piranha
Create a virtual environment:
python3 -m venv .env
source .env/bin/activate
Install Polyglot Piranha
pip install --upgrade pip
pip install . to run demo against current source code (please install Rust, it takes less than a minute)
Or, pip install polyglot-piranha to run demos against the latest release.

eankit · 2022-12-09T18:05:49Z

however running cargo build --no-default-features also gives me the following error, not sure what I am doing wrong ?

error[E0308]: mismatched types
--> src/models/language.rs:154:19
|
154 | language: tree_sitter_typescript::language_typescript(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

error[E0308]: mismatched types
--> src/models/language.rs:163:19
|
163 | language: tree_sitter_typescript::language_tsx(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

For more information about this error, try rustc --explain E0308.
error: could not compile piranha due to 2 previous errors

ketkarameya · 2022-12-09T18:06:09Z

Can you please try cargo build --no-default-features after cd piranha/polyglot/piranha step ?

eankit · 2022-12-09T18:08:45Z

@ketkarameya I wish I could share my screen

anbhanda@Ankits-MacBook-Pro-6 piranha % git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
anbhanda@Ankits-MacBook-Pro-6 piranha % cargo build --no-default-features
Compiling piranha v0.2.1 (/Users/anbhanda/Documents/Pirahnah_Polygot/piranha/polyglot/piranha)
error[E0308]: mismatched types
--> src/models/language.rs:154:19
|
154 | language: tree_sitter_typescript::language_typescript(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

error[E0308]: mismatched types
--> src/models/language.rs:163:19
|
163 | language: tree_sitter_typescript::language_tsx(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

For more information about this error, try rustc --explain E0308.
error: could not compile piranha due to 2 previous errors

ketkarameya · 2022-12-09T18:10:25Z

hmmm. Let me think. Can you see if installing tree-sitter cli help?
https://github.com/tree-sitter/tree-sitter/blob/master/cli/README.md

ketkarameya · 2022-12-09T18:12:38Z

Also can you start in a fresh directory?

git clone ...
cd piranha/polyglot/piranha directory.
cargo build --no-default-features

I think maturin has messed up your deps :|

eankit · 2022-12-09T18:24:05Z

@ketkarameya
Started in a fresh directory works fine for existing code!!!!
Thanks for your help, will start with making changes for Scala now.
Any suggestions that you want me to follow before starting up with the changes in language.rs and cargo.toml
Or do you feel it will be more changes required before I start to write the rules for scala

ketkarameya · 2022-12-10T16:35:36Z

Hey! I think once u add that struct for scala you will need to write rules (no more rust changes)

eankit · 2022-12-11T08:59:47Z

It compiles will with adding scala dependency in cargo.toml file but compilation fails with following error
It looks to me a rust issue
rust-lang/cargo#8536

anbhanda@-MacBook-Pro-6 piranha % cargo build --release --no-default-features
Compiling piranha v0.2.1 (/Users/anbhanda/Documents/Pirahnah_Polygot_2/piranha/polyglot/piranha)
error[E0308]: mismatched types
--> src/models/language.rs:172:19
|
172 | language: tree_sitter_scala::language(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct tree_sitter::Language, found a different struct tree_sitter::Language
|
= note: perhaps two different versions of crate tree_sitter are being used?

For more information about this error, try rustc --explain E0308.
error: could not compile piranha due to previous error
PS: I compiles just after doing git clone and making the required changes

ketkarameya · 2022-12-11T16:04:02Z

Yes, I is a tree-sitter version mismatch. So we (Piranha) is using 0.20.6, while tree-sitter scala is using 0.19.

I would recommend upstreaming the version update change for tree-sitter scala to something like this.
While the upstream accepts your changes, you can make a fork of tree-sitter-scala, update the tree-sitter version in a particular branch and point to this fork & branch of tree-sitter-scala (this will allow you to continue to experiment with piranha) in Piranha's Cargo.toml. Let me know if this works for you .

ketkarameya · 2022-12-11T16:08:04Z

This latest PR adds built-in cleanup rules for Go.
#265

You can use it as reference :)

eankit · 2022-12-12T13:56:50Z

@ketkarameya thanks a lot, forking scala tree-sitter worked.
Currently struggling with comprehending query language for scala, any help in this regard will be appreciated.

ketkarameya · 2022-12-13T19:21:18Z

Hmmm. yea.
Did you read the README throughly (specially this)? Where are you stuck at ? Can you make a PR for any work you have in progress

ketkarameya · 2022-12-14T21:49:57Z

@eankit. Can you create a PR for just adding Scala to Piranha ?
We can take it from there, one step at a time.

ketkarameya added the New Language Support label Aug 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does Piranha support scala projects #199

Does Piranha support scala projects #199

eankit commented Jun 27, 2022

mkr-plse commented Jul 11, 2022

ketkarameya commented Jul 11, 2022

eankit commented Dec 6, 2022 •

edited

Loading

ketkarameya commented Dec 6, 2022 •

edited

Loading

eankit commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022

eankit commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

ketkarameya commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 10, 2022

eankit commented Dec 11, 2022

ketkarameya commented Dec 11, 2022 •

edited

Loading

ketkarameya commented Dec 11, 2022

eankit commented Dec 12, 2022

ketkarameya commented Dec 13, 2022

ketkarameya commented Dec 14, 2022

Does Piranha support scala projects #199

Does Piranha support scala projects #199

Comments

eankit commented Jun 27, 2022

mkr-plse commented Jul 11, 2022

ketkarameya commented Jul 11, 2022

eankit commented Dec 6, 2022 • edited Loading

ketkarameya commented Dec 6, 2022 • edited Loading

eankit commented Dec 9, 2022 • edited Loading

ketkarameya commented Dec 9, 2022 • edited Loading

eankit commented Dec 9, 2022

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022 • edited Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022 • edited Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022

eankit commented Dec 9, 2022 • edited Loading

ketkarameya commented Dec 9, 2022

eankit commented Dec 9, 2022

ketkarameya commented Dec 9, 2022

ketkarameya commented Dec 9, 2022 • edited Loading

eankit commented Dec 9, 2022

ketkarameya commented Dec 10, 2022

eankit commented Dec 11, 2022

ketkarameya commented Dec 11, 2022 • edited Loading

ketkarameya commented Dec 11, 2022

eankit commented Dec 12, 2022

ketkarameya commented Dec 13, 2022

ketkarameya commented Dec 14, 2022

eankit commented Dec 6, 2022 •

edited

Loading

ketkarameya commented Dec 6, 2022 •

edited

Loading

eankit commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022 •

edited

Loading

eankit commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 9, 2022 •

edited

Loading

ketkarameya commented Dec 11, 2022 •

edited

Loading