[bug]: Incorrect diff produced for if expression

[swayamraina]

was working on #35 but it seems there is an issue in the current master branch where expressions are not correctly handled in if statements

to reproduce simply change the implementation in sample app (MyClass.bak)

  public void bar(boolean base) {
    if (base && expt.flagDisabled(TestExperimentName.SAMPLE_STALE_FLAG)) {
      System.out.println("Hi World");
    }
  }

The output diff is,

  public void bar(boolean y) {

  }

[mkr-plse]

See the configuration option here. Since the conditionalExpression evaluates to false, the output is indeed correct.

Please re-open if you see this behavior when the configuration option is changed.

[swayamraina]

Shouldn't the diff file be,

  public void bar(boolean base) {
    if (base) {
      System.out.println("Hi World");
    }
  }

as the boolean base is a base check and the feature is checked only after the base passes.

[mkr-plse]

Independent of base, expt.flagDisabled(TestExperimentName.SAMPLE_STALE_FLAG) will return false when flag is treated. So, the entire conditional expression evaluates to false.
Try this example when treated is changed to control.