-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This repository is currently inactive but we're looking for maintainers #1303
Comments
Hi @chrisirhc and @gergelyke react-viz have been an amazing library for a lot of my projects. It's sad that there's no active maintainer for such an awesome library, but rather than seeing this library being deprecated I like ownership of this project. |
This really is too bad. This library has some weakness like any library. Like @thisis-Shitanshu comment, this library has incredible potential. I am wondering now why Uber wasn't investing in this library... is there something better they found? |
There's an increasing trend in visualization libraries to shift away from imperative visualization declaration (e.g. put this circle here) to declarative declarations (gimmie an x/y plot with circles). While react-vis has always been a little towards the latter it doesn't feature the rich grammar of graphics style declarations that libraries like ggplot or vega-lite/altair feature. It's hard to see it go, but it's also very much a visualization library of a particular era (specifically the react-ify-everything-stylings of 2015-6). I definitely still find myself using react-vis a reasonable amount, but more and more I also find myself using vega-embed/react-vega and the like. |
@thisis-Shitanshu you can help by playing a maintainer role and reviewing the PRs.
We simply don't have the resources to do so. Nobody in the company has stepped up to take ownership as a maintainer. |
@chrisirhc I have always admired @mcnuttandrew 's work, his contributions have been a huge inspiration for me. I understand it takes a lot of time and effort to be a maintainer for such a huge project but if nobody is stepping in to maintain this awesome project, rather than see it being depreciated I would love to volunteer and take ownership of this project as a maintainer. I will contribute my time in reviewing PRs and add features to this library so it always stands as one of the best charting libraries. |
@thisis-Shitanshu I've sent you an invite for push rights so you have permissions to move ahead to take actions as a maintainer. |
@chrisirhc Thank you so much for the invite! Whenever convenient for you, I would absolutely love to chat about the next steps. |
This is one of my favourite visualization libs. Could you please also add me as a collaborator/maintainer. So that I can also share or push my code and features that I have used in my project which is built on top of React-Vis. |
That's actually why I love |
@krushanu me and @thisis-Shitanshu are chatting. |
I really enjoyed using this library on a recent project before reading about the deprecation. Has there been progress on the new maintainers ? |
Unfortunately, not much progress to report on finding maintainers. |
Hi @chrisirhc, how is the migration to Styletrong helping to find maintainers? Is Uber making any effort in that direction? Or is that assumption just a guess from your own? |
Uber has no resources to maintain this library and we've been looking for maintainers for a while now. At this point, I don't think you can expect anything. This is open source software and we've already given strong indication that there is no support. If no one is willing to give and contribute into the project in the way it needs, then there simply is nothing you can expect. Update: I might be completely wrong and people want a CSS styled charting library. I only know it's not the case at Uber. Either way, we welcome maintainers or forks. |
My question is related on how migrating to Styletron can help to find maintainers. What charting library is Uber using now if no longer using |
Thanks for your questions, @dpordomingo.
Internally, there's been use of echarts, Nivo, Highcharts, and still some level of usage of react-vis. There hasn't been a standard charting library used.
Internally, the answer is yes as we can get help from the team that maintains BaseWeb, Styletron, and FusionJS. react-vis is uses scss which is no longer a best practice nor is it tightly compatible with these new libraries/frameworks which are widely used at Uber.
I'm also curious to learn if the community would still like this library once it's modernized and using styletron. Perhaps the only way to find out is to take a stab and converting some charts and making a new release. |
I've put together a RFC proposal for a strategy to move onto Styletron on chrisirhc#1 It's still in iteration but please comment on it if you have any thoughts. Potentially, we can collaborate to finish this on a branch of react-vis and revive the project. |
@chrisirhc I looked at your proposal and I like the idea! |
Thanks to @Xiot and @a-peltier putting in a big push this week, we've gotten some contributions going to get things started again. The master branch now contains a bunch of development experience improvements. We have a Slack to discuss development. Please reach out if you're interested to collaborate. |
👍 |
I can see that the deprecation warning has been removed 🎉 . Does this mean that active development is going to start again? I had started looking for other alternatives like recharts, victory, but if react-vis is not going to be deprecated anymore, I would probably continue with it. Is there a roadmap with future plans? |
Unfortunately, the work that was going on lost steam, so there's no current work being planned for the library. |
Could this remain pinned? Maybe mentioned in README? It's quite important information when deciding which library to use. |
@chrisirhc I like to be a maintainer for this project. |
@chrisirhc can we have a discussion about this library development? |
Watching the discussion. And i can help too! |
We have decided to deprecate this library as we don't have an active maintainer.
If you'd like to take take ownership, please feel free to fork or discuss over here.
( #1248 (comment) )
The text was updated successfully, but these errors were encountered: