Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Modernize repository #1316

Open
2 of 7 tasks
chrisirhc opened this issue May 18, 2020 · 6 comments
Open
2 of 7 tasks

RFC Modernize repository #1316

chrisirhc opened this issue May 18, 2020 · 6 comments

Comments

@chrisirhc
Copy link
Contributor

chrisirhc commented May 18, 2020

From offline sync with @Xiot

@reitlepax
Copy link
Contributor

I'm willing to try to convert some components to hooks, for instance I can make a PR to the modernize branch, sounds good ?

@chrisirhc
Copy link
Contributor Author

I'm willing to try to convert some components to hooks, for instance I can make a PR to the modernize branch, sounds good ?

Yep, that sounds good. We may need to rebase it after #1317 .

@Xiot would that be easier or should we start with the yarn workspaces branch?

@Xiot
Copy link
Contributor

Xiot commented May 21, 2020

Probably start with the yarn workspace branch. I can merge that into modernize once I clean it up.

@thetylerreiff
Copy link

thetylerreiff commented May 22, 2020

Hey all, I would recommend starting with yarn workspace then we can dig into the rest. I’ll gladly implement hooks as needed 👍

I have experience with workspaces if that’s something you want me to look at or help out with.

@Xiot
Copy link
Contributor

Xiot commented May 22, 2020

@reiff12 We've already started on moving over to yarn workspaces #1317
Moving to use workspaces was fairly simple. The fun part is updating the dependencies throughout. I almost have everything working, and its just mainly the website project that doesn't build due to ocular

@chrisirhc
Copy link
Contributor Author

At this point, the docs generation is the main challenge before we can merge the workspaces PR. Though I think it's ok to merge it before we have it fully worked out, since the website build has been broken for a while now.

@ibgreen : what doc practices are you all following for your projects? Is there a repo that shows your latest docs practices? Perhaps we could leverage them here and it might be less work to migrate to that compared to rethinking how to generate docs here.

Separately, for folks interested in looking at the hooks conversion: how about putting up some RFCs/proposals on approaches for discussion via #1320?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants