Skip to content

Commit

Permalink
Merge pull request #101 from uber/lu.log
Browse files Browse the repository at this point in the history
Log unexpected tchannel system error
  • Loading branch information
ChuntaoLu committed May 20, 2017
2 parents dff0b03 + 97f3777 commit 51262c8
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion runtime/tchannel_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@ func (s *TChannelRouter) handle(ctx context.Context, handler handler, service st
if er := reader.Close(); er != nil {
return errors.Wrapf(er, "could not close arg3reader for inbound call: %s::%s", service, method)
}
return call.Response().SendSystemError(err)
s.logger.Error("Unexpected tchannel system error",
zap.String("service", service),
zap.String("method", method),
zap.String("error", err.Error()),
)
return call.Response().SendSystemError(errors.New("Server Error"))
}

if err := EnsureEmpty(reader, "reading request body"); err != nil {
Expand Down

0 comments on commit 51262c8

Please sign in to comment.