Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache requests to google Api #32

Closed
izziaraffaele opened this issue Sep 8, 2015 · 2 comments
Closed

Cache requests to google Api #32

izziaraffaele opened this issue Sep 8, 2015 · 2 comments

Comments

@izziaraffaele
Copy link

From google doc

Geocoding is a time and resource intensive task. Whenever possible, pre-geocode known addresses (using the Google Maps Geocoding API described here or another geocoding service), and store your results in a temporary cache of your own design.

A basic implementation can be found on the PR I submitted #29
@ro-ka
Copy link
Contributor

ro-ka commented Sep 9, 2015

That’s great – could you prepare a PR with cherry picked changes for the caching?

@ro-ka
Copy link
Contributor

ro-ka commented May 27, 2016

The browser caches the Google requests already. So no need for an individual implementation.

See the screenshot. I typed “Rio” twice:

@ro-ka ro-ka closed this as completed May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ro-ka @izziaraffaele